michael-s-molina commented on a change in pull request #13186:
URL: https://github.com/apache/superset/pull/13186#discussion_r579162150
##########
File path: superset-frontend/spec/javascripts/sqllab/SqlEditor_spec.jsx
##########
@@ -72,22 +78,26 @@ describe('SqlEditor', () => {
},
);
- it('render a SqlEditorLeftBar', () => {
+ it('render a SqlEditorLeftBar', async () => {
Review comment:
They don't work. I think they are really old tests. One of them is using
setState but the component is a functional component now and it seems that the
height logic being tested is also different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
