rusackas opened a new pull request #13254:
URL: https://github.com/apache/superset/pull/13254


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   The `Button` component had some styles to adjust margins of consecutive 
sibling buttons. This wasn't working in all cases since some were rendered as 
different element types (`button` or `a`). This PR adds a (library agnostic) 
class to the `Button` elements, so that they can be spaced more reliably using 
an Adjascent Sibling Selector (`+`).
   
   I also pulled out the `grid-gap` from `.ResultSetButtons` since the above 
adjustments take care of the spacing.
   
   This also includes a little bycatch of a seemingly unnecessary 
`React.Fragment`
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   Before:
   
![image](https://user-images.githubusercontent.com/812905/108586556-1e478880-7304-11eb-9600-0defa0ee37da.png)
   
   After:
   
![image](https://user-images.githubusercontent.com/812905/108586542-06700480-7304-11eb-92a8-020217e8b8c3.png)
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Screenshots look right
   Storybook looks good
   Other buttons elsewhere in the UI show no fallout.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   reviews welcome from @eschutho @AAfghahi (or anyone else, of course)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to