simcha90 commented on a change in pull request #12920:
URL: https://github.com/apache/superset/pull/12920#discussion_r580010165
##########
File path: superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx
##########
@@ -145,13 +146,38 @@ export default class SqlEditorLeftBar extends
React.PureComponent {
<div className="divider" />
<StyledScrollbarContainer>
<StyledScrollbarContent contentHeight={tableMetaDataHeight}>
- {this.props.tables.map(table => (
- <TableElement
- table={table}
- key={table.id}
- actions={this.props.actions}
- />
- ))}
+ <Collapse
+ ghost
+ expandIconPosition="right"
+ css={theme => css`
Review comment:
I know that this discussion already closed, but anyway I'd like still
ask about something that looks strange for me:
```You colocate styles with elements```
Actually when you have some more complex component not like simple button,
when you start mix styles with JSX/JS logic you miss JSX structure of component
because styles can take a lot of place, and also some js logic can be missed
from eye
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
