nytai opened a new pull request #13283: URL: https://github.com/apache/superset/pull/13283
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> https://github.com/apache/superset/pull/13087 made some change to the menu links, trying to standardize routes to always end in an `/`, which should make matching between frontend routes and backend routes easier. When a route is `@expose`d, and ends in a `/`, flask automatically redirects urls that do not end in a `/` to the correct endpoint. This behavior does not happen when the route is `@expose`d without the trailing `/`. It looks like FAB `@expose`s most endpoints to end in a `/`, except for the `/form` route, which has resulted in some 404s for the menu links. This PR addresses the issue by changing the `@expose`d routes to end in a `/`, except for the case of the FAB `form` route, where this is not possible, the trailing `/` is removed from the menu links. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN <!--- What steps should be taken to verify the changes --> - Menu link for `/csvtodatabaseview/form` does not 404 - Menu link for `/exceltodatabaseview/form` does not 404 - Menu link for `/superset/import_dashboards/` does not 404 ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
