nytai commented on a change in pull request #13220:
URL: https://github.com/apache/superset/pull/13220#discussion_r580395779
##########
File path: superset-frontend/src/explore/components/ExploreViewContainer.jsx
##########
@@ -35,6 +35,7 @@ import {
setInLocalStorage,
} from 'src/utils/localStorageHelpers';
import { URL_PARAMS } from 'src/constants';
+import cls from 'classnames';
Review comment:
The codebase has been using `cx` as the import for this module.
##########
File path: superset-frontend/src/views/Store.tsx
##########
@@ -0,0 +1,35 @@
+/**
Review comment:
The pattern so far has been to only capitalize file names if they
include a react component. I'm also not seeing any `jsx` in this file, so
`store.ts` would be a better name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
