rusackas edited a comment on pull request #12229: URL: https://github.com/apache/superset/pull/12229#issuecomment-783633552
> cc @Steejay @mihir174 > Looks great. Only question I have is whether we can we still use custom icons when designers want something new or different? Indeed! This is built specifically for that, so we can effectively extend/override the AntD icon set, rather than having custom icons that are a bit of an interface mismatch from the AntD icons we'd use elsewhere. In fact, plans are underway to revamp our custom icons in the design system to better match the layout/sizing of the AntD icons. We'll get them all to play nicely together. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
