betodealmeida opened a new pull request #13288: URL: https://github.com/apache/superset/pull/13288
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Currently the state of whether we should show the left bar in SQL Lab is **global**, not per tab. Since this is configured separately in each tab menu, it makes sense to track the state individually. This PR moves the state of the left bar to the query editor, using the redux store to toggle its display. If the `SQLLAB_BACKEND_PERSISTENCE` is enabled the visibility is stored on the backend as well. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> N/A ### TEST PLAN <!--- What steps should be taken to verify the changes --> 0. `SQLLAB_BACKEND_PERSISTENCE` set to off. 1. Created a few tabs, changed their visibility, verified that visibility is defined per tabs and persists on page refresh. 2. Turn `SQLLAB_BACKEND_PERSISTENCE` on, reload SQL Lab, verified that tabs' state was migrated to the backend. 3. Toggle visibility, verified state is persisted in the backend and loaded correctly on page refresh and tab switch. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
