[GitHub] [superset] rwspielman opened a new pull request #12937: fix: chart keys in MultiLineViz

Mon, 22 Feb 2021 23:22:33 -0800 


rwspielman opened a new pull request #12937:
URL: https://github.com/apache/superset/pull/12937


   ### SUMMARY
   fixing multi-line viz issue of incorrectly formatted text for chart key when 
single line chart is used as a data
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **Before**
   <img width="1017" alt="BeforeMultiLinVizFix" 
src="https://user-images.githubusercontent.com/20442310/106868364-4d1ef700-6694-11eb-8be1-f3d12764fadd.png";>
   
   **After**
   <img width="1012" alt="AfterMultiLineVizFix" 
src="https://user-images.githubusercontent.com/20442310/106868365-4db78d80-6694-11eb-8abb-3b64a55764cc.png";>
   
   
   ### TEST PLAN
   Observe correctly formatted key for data in API call for both multi-line 
charts and single-line charts as a chart source
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #12935 
   - [x] Fixes #12935 
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to