[GitHub] [superset] kgabryje commented on a change in pull request #13210: feat(explore): ColumnSelectControl with drag-and-drop

Tue, 23 Feb 2021 04:54:13 -0800 


kgabryje commented on a change in pull request #13210:
URL: https://github.com/apache/superset/pull/13210#discussion_r581010736



##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -204,7 +206,12 @@ export default function DataSourcePanel({
             </div>
             {metricSlice.map(m => (
               <LabelContainer key={m.metric_name} className="column">
-                <MetricOption metric={m} showType />
+                <DatasourcePanelDragWrapper
+                  metricOrColumnName={m.metric_name}
+                  type={DatasourcePanelDndType.METRIC}
+                >
+                  <MetricOption metric={m} showType />

Review comment:
       I mean that here we could use `cursor: move` to indicate that the label 
is draggable 
   
![image](https://user-images.githubusercontent.com/15073128/108846169-8d5ffe00-75de-11eb-9b73-b3991316634c.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to