ktmud commented on a change in pull request #13221:
URL: https://github.com/apache/superset/pull/13221#discussion_r578695232
##########
File path: superset-frontend/src/explore/components/ControlPanelsContainer.tsx
##########
@@ -161,29 +178,39 @@ class ControlPanelsContainer extends React.Component {
validationErrors={validationErrors}
actions={actions}
formData={provideFormDataToProps ? formData : null}
- datasource={formData?.datasource}
Review comment:
Remove this exposed `datasource` prop from #12609 since it's already
available in `formData`, plus The typing would not conform with `datasource`
for `DatasourceControl`, which uses the assigns `datasource` prop with the
whole metadata of a datasource in `mapStateToProps`.
cc @pkdotson @zhaoyongjie
##########
File path: superset-frontend/src/explore/controls.jsx
##########
@@ -355,8 +355,9 @@ export const controls = {
"using the engine's local timezone. Note one can explicitly set the
timezone " +
'per the ISO 8601 format if specifying either the start and/or end
time.',
),
- mapStateToProps: state => ({
- endpoints: state.form_data ? state.form_data.time_range_endpoints : null,
+ provideFormDataToProps: true,
Review comment:
Need to add this in `superset-ui/chart-controls`, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
