villebro commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r582605459
##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -45,6 +48,28 @@ class PostgresBaseEngineSpec(BaseEngineSpec):
engine = ""
engine_name = "PostgreSQL"
+ column_type_mappings = (
Review comment:
Yes - this is the ultimate objective. However, we want to leave the
existing structures untouched until we're certain this doesn't break existing
functionality. We'll be including other types in this mapping that are missing
in `db_column_types`, like `DbColumnType`, PyArrow types etc to make sure this
is a one-stop-shop for making available all necessary types in one place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
