john-bodley opened a new pull request #13331:
URL: https://github.com/apache/superset/pull/13331


   ### SUMMARY
   
   I'm really perplexed why this issue has recently surfaced and/or been 
reported and why it only applies to certain visualization types (is there any 
chance 
[this](https://github.com/apache-superset/superset-ui/blob/master/packages/superset-ui-core/src/query/extractExtras.ts)
 is overridden by various chart types), but it seems like the Python date 
format wasn't being adhered to due to poorly formed extra time-range-endpoints.
   
   More specifically for the QueryObject the `extra` fields are coming from 
`superset-ui` where, if defined, the `time_range_endpoints` is a tuple of 
strings which are never converted to a tuple of `TimeRangeEndpoint` enums and 
thus 
[this](https://github.com/apache/superset/blob/0a00153375fb69891c2a9f0115a33cdf5551b2d6/superset/connectors/sqla/models.py#L309)
 check is false meaning the default date format is never adhered to.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   
   CI.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to