kgabryje opened a new pull request #13340:
URL: https://github.com/apache/superset/pull/13340


   ### SUMMARY
   This PR is based on https://github.com/apache/superset/pull/13210 by 
@zhaoyongjie. Once https://github.com/apache/superset/pull/13210 is merged, 
this PR needs to get rebased onto master.
   
   The goal was to implement creating adhoc filters by dragging columns from 
datasource panel to filters control. Also, I  attempted to make Yongjie's 
implementation more generic, so that we can reuse components with filters and, 
in the future, with metrics controls.
   
   CC: @villebro @zhaoyongjie @ktmud @junlincc 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
https://user-images.githubusercontent.com/15073128/109182131-f9806480-778c-11eb-97bc-fef2b579bb2f.mov
   
   ### TEST PLAN
   Pull https://github.com/apache-superset/superset-ui/pull/978, link 
chart-controls to Superset, set `ENABLE_EXPLORE_DRAG_AND_DROP` feature flag.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to