etr2460 commented on a change in pull request #13307:
URL: https://github.com/apache/superset/pull/13307#discussion_r583375565
##########
File path: superset/connectors/sqla/models.py
##########
@@ -1465,6 +1465,12 @@ def has_extra_cache_key_calls(self, query_obj:
QueryObjectDict) -> bool:
for statement in templatable_statements:
if ExtraCache.regex.search(statement):
return True
+
+ # Always recalculate the cache keys since the SQL query mutator can
modify the
+ # query in arbitrary ways
+ if config["SQL_QUERY_MUTATOR"]:
+ return True
+
Review comment:
yeah, i think i'm going to abandon this PR, I agree the performance
issues could be pretty bad
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
