john-bodley commented on a change in pull request #13331:
URL: https://github.com/apache/superset/pull/13331#discussion_r583922739
##########
File path: superset/common/query_object.py
##########
@@ -181,8 +181,10 @@ def __init__(
self.order_desc = order_desc
self.extras = extras
- if config["SIP_15_ENABLED"] and "time_range_endpoints" not in
self.extras:
- self.extras["time_range_endpoints"] =
get_time_range_endpoints(form_data={})
+ if config["SIP_15_ENABLED"]:
+ self.extras["time_range_endpoints"] = get_time_range_endpoints(
+ form_data=self.extras
+ )
Review comment:
@ktmud this change captures the sentiment of the test, i.e., ensuring
that the in `extras` the data is encoded as an enum rather than string, unless
I'm confused regarding the `ChartDataQueryContextSchema` behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
