eschutho commented on a change in pull request #13346:
URL: https://github.com/apache/superset/pull/13346#discussion_r583963006
##########
File path: superset/databases/commands/create.py
##########
@@ -69,8 +64,9 @@ def run(self) -> Model:
security_manager.add_permission_view_menu("database_access",
database.perm)
db.session.commit()
except DAOCreateFailedError as ex:
- logger.exception(ex.exception)
- raise DatabaseCreateFailedError()
+ with
event_logger.log_context(action=f"db_creation_failed.{ex.exception}"):
Review comment:
since we're merging this branch into @hughhhh's feature branch rather
than master, @betodealmeida said that he could do the log_context refactor in a
separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
