eschutho commented on a change in pull request #13349:
URL: https://github.com/apache/superset/pull/13349#discussion_r584026496
##########
File path: superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
##########
@@ -30,17 +29,17 @@ import { storeQuery } from 'src/utils/common';
import { getClientErrorObject } from 'src/utils/getClientErrorObject';
import { FeatureFlag, isFeatureEnabled } from '../../featureFlags';
-const propTypes = {
- queryEditor: PropTypes.shape({
- dbId: PropTypes.number,
- title: PropTypes.string,
- schema: PropTypes.string,
- autorun: PropTypes.bool,
- sql: PropTypes.string,
- remoteId: PropTypes.number,
- }).isRequired,
- addDangerToast: PropTypes.func.isRequired,
-};
+interface propTypes {
+ queryEditor: {
+ dbId: number;
+ title: string;
+ schema: string;
+ autorun: boolean;
+ sql: string;
+ remoteId: number;
+ };
+ addDangerToast: (msg: string) => void;
Review comment:
oh, and this one. the rest we can mark optional or null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
