dpgaspar commented on pull request #13157: URL: https://github.com/apache/superset/pull/13157#issuecomment-787825096
> > it is, it's sort of a breaking change because the new reports will now change its image size. I think it would be more flexible to have the 2 new config keys. Let the new reports still take the screenshot with the previous size, but making it now possible for everyone to configure it > > thoughts? > > I think adding 2 different config may get configuration more complicated from point of view of a user. Also I'm not sure thumbnail size should be configurable. Good point, but still seems weird to me that by configuring `WEBDRIVER_WINDOW` we only end up configuring the new alerts & reports window, while thumbnails is hardcoded. Not explicit nor obvious. But this looks good, and I don't want to stale this fix for long. Thank you for your contribution and patience ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
