rusackas commented on a change in pull request #13358: URL: https://github.com/apache/superset/pull/13358#discussion_r585048294
########## File path: superset-frontend/src/components/ErrorMessage/BasicErrorAlert.test.tsx ########## @@ -0,0 +1,96 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import React from 'react'; +import { render, screen } from 'spec/helpers/testing-library'; +import { supersetTheme } from '@superset-ui/core'; +import BasicErrorAlert from './BasicErrorAlert'; +import { ErrorLevel } from './types'; + +const mockedProps = { + body: 'Error body', + level: 'warning' as ErrorLevel, + title: 'Error title', +}; + +jest.mock('../Icon', () => ({ + __esModule: true, + default: ({ name }: { name: string }) => ( + <div data-test="icon" data-name={name} /> + ), +})); + +test('should render', () => { + const { container } = render(<BasicErrorAlert {...mockedProps} />); + expect(container).toBeInTheDocument(); +}); + +test('should render warning icon', () => { + render(<BasicErrorAlert {...mockedProps} />); + expect(screen.getByTestId('icon')).toBeInTheDocument(); + expect(screen.getByTestId('icon')).toHaveAttribute( + 'data-name', + 'warning-solid', + ); +}); + +test('should render error icon', () => { + const errorProps = { + ...mockedProps, + level: 'error' as ErrorLevel, + }; + render(<BasicErrorAlert {...errorProps} />); + expect(screen.getByTestId('icon')).toBeInTheDocument(); + expect(screen.getByTestId('icon')).toHaveAttribute( + 'data-name', + 'error-solid', + ); +}); + +test('should render the error title', () => { + render(<BasicErrorAlert {...mockedProps} />); + expect(screen.getByText('Error title')).toBeInTheDocument(); +}); + +test('should render the error body', () => { + render(<BasicErrorAlert {...mockedProps} />); + expect(screen.getByText('Error body')).toBeInTheDocument(); +}); + +test('should render with warning theme', () => { + render(<BasicErrorAlert {...mockedProps} />); + expect(screen.getByRole('alert')).toHaveStyle( + ` + backgroundColor: ${supersetTheme.colors.warning.light2}; Review comment: Not sure this is even a nit as much as just something to point out. The `render` function is passing the `theme` in, so these sorts of tests seem to just test _that_. Which is fine, I suppose. But also maybe worth noting that we're asserting the supersetTheme color here by direct invocation. This is interesting (and potentially useful) in that the `<ThemeProvider>` in the App(s) can be (and likely _will_ be) used to mutate the theme (e.g. override it, invert it, etc). So when we get to testing all of that stuff, these tests will get more interesting :D ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
