ktmud commented on a change in pull request #13401: URL: https://github.com/apache/superset/pull/13401#discussion_r586002144
########## File path: superset-frontend/src/explore/controlUtils/getControlConfig.ts ########## @@ -0,0 +1,68 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import memoizeOne from 'memoize-one'; +import { getChartControlPanelRegistry } from '@superset-ui/core'; +import { + ControlPanelSectionConfig, + expandControlConfig, +} from '@superset-ui/chart-controls'; + +const getMemoizedControlConfig = memoizeOne( + (controlKey, controlPanelConfig) => { + const { + controlOverrides = {}, + controlPanelSections = [], + } = controlPanelConfig; + const control = expandControlConfig( + findControlItem(controlPanelSections, controlKey), + controlOverrides, + ); + return control && 'config' in control ? control.config : control; + }, +); + +/** + * Find control item from control panel config. + */ +export function findControlItem( + controlPanelSections: ControlPanelSectionConfig[], + controlKey: string, +) { + return ( + controlPanelSections + .map(section => section.controlSetRows) + .flat(2) + .find( + control => + controlKey === control || + (control !== null && + typeof control === 'object' && + 'name' in control && + control.name === controlKey), + ) ?? null + ); +} + +export const getControlConfig = function getControlConfig( + controlKey: string, + vizType: string, Review comment: Unfortunately it doesn't. I've thought about creating a `VizType` and actually did create a temporary type in an earlier iteration: ```ts // TODO: replace this with string literals of actual supported viz types type VizType = string; ``` But decided against it because it may not work well with dynamic plugins where viz types could be anything. If we do still find value in restricting viz types, we can do that while we convert `MainPreset.js` to TS. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
