michellethomas opened a new pull request #13425:
URL: https://github.com/apache/superset/pull/13425


   ### SUMMARY
   We see errors editing the metadata for dashboards that were imported using 
the v0 import/export feature. I'm adding those fields to the 
DashboardJSONMetadataSchema so we don't see those errors on validation. I'm 
adding these fields to the schema instead of removing them because the v0 
import/export feature 
[uses](https://github.com/apache/superset/blob/45738ffc1dfe94deb6578b6e5b0d6687558969e9/superset/dashboards/commands/importers/v0.py#L49-L50)
 them. 
   
   I tested this change by editing a chart with these fields, let me know if 
there's anything else to test with this change.
   
   ### TEST PLAN
   I tested editing a chart that had these fields in the dashboard 
`json_metadata`.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: Fixes #10742
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   @betodealmeida @dpgaspar @serenajiang 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to