michael-s-molina commented on pull request #13422: URL: https://github.com/apache/superset/pull/13422#issuecomment-789773747
> Specifically in this case, adding the `role` does not seem like a good option/best practices. @yardz I think you misunderstood what I said. The roles are already available to you because you are using a native HTML table. It's similar to `<button>`, you don't need to explicitly add a role. Anytime you want to know which roles are available you can always use [logRoles](https://testing-library.com/docs/dom-testing-library/api-accessibility/#logroles) helper function. If you execute this in `TableCollection.test.tsx` you will see that the roles are already there. ``` import { render, screen, logRoles } from 'spec/helpers/testing-library'; ... const { container } = render(<TableCollection {...(props as any)} />); logRoles(container); ... ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
