dpgaspar commented on a change in pull request #13444:
URL: https://github.com/apache/superset/pull/13444#discussion_r587341766
##########
File path: superset/dashboards/commands/importers/v0.py
##########
@@ -317,7 +317,10 @@ class ImportDashboardsCommand(BaseCommand):
in Superset.
"""
- def __init__(self, contents: Dict[str, str], database_id: Optional[int] =
None):
+ # pylint: disable=unused-argument
+ def __init__(
+ self, contents: Dict[str, str], database_id: Optional[int] = None,
**kwargs: Any
Review comment:
is contents a flat `Dict`? also why the `kwargs` here, they receive
`passwords` and `overwrite` but nothing is done with them, I'm probably missing
something.
It would be nice also to add a description for the fields on the API spec:
```
schema:
type: object
properties:
formData:
type: string
format: binary
passwords:
type: string
overwrite:
type: bool
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
