michael-s-molina commented on pull request #13409: URL: https://github.com/apache/superset/pull/13409#issuecomment-790550534
@rusackas I changed to use `gridUnit` instead of `3px` and also replaced `useTheme` with typed `theme: SupersetTheme` prop 😉. About CSS-y approach I understand that it doesn't require switching the brain from CSS to JS styles but I still think that type checking is a clear winner. Let me know if you agree. Otherwise, I can revisit. Thank you for your review. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
