dpgaspar commented on pull request #13389:
URL: https://github.com/apache/superset/pull/13389#issuecomment-790770608
> Hmmm, does this mean that to only change one column/metric you need to
send a payload with all the other columns/metrics and all their attributes
along with it? That's not ideal since we have a dataset with over 10k metrics
and 5k columns.
>
> Could we instead add the api directly onto the SqlMetric and SqlColumn
models? I think it makes sense to create, update, and delete these outside the
scope of the Dataset, as long as when creating them you add the dataset ID
I understand, took the decision because the current process works with a
full payload and the frontend modal (although it targets a different endpoint)
has the same logic. Do you notice any problems with it?
I'll add 2 additional endpoints to delete:
`/api/v1/datasets/<id>/metric/<id>` HTTP DELETE
`/api/v1/datasets/<id>/column/<id>` HTTP DELETE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
