ktmud opened a new pull request #13473:
URL: https://github.com/apache/superset/pull/13473


   ### SUMMARY
   
   Closes #13423
   
   #13057 Added sortby metrics for some multi-series charts but it causes 
duplicate metrics and wrong queries. 
   
   This is a bandaid PR to quickly fix the issue from the surface. I'm making 
the handling of sort by metrics more robust in #13434 .
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before
   
   
![Snip20210304_25](https://user-images.githubusercontent.com/335541/110076240-04149e00-7d39-11eb-9c68-2abe10b388de.png)
   
![Snip20210304_26](https://user-images.githubusercontent.com/335541/110076251-0971e880-7d39-11eb-8bbc-13b224066b2e.png)
   
   
   #### After
   
   
![Snip20210304_28](https://user-images.githubusercontent.com/335541/110076322-23133000-7d39-11eb-837c-07d7b113c9a4.png)
   
   
![Snip20210304_27](https://user-images.githubusercontent.com/335541/110076293-1989c800-7d39-11eb-9c22-f40aaec902e6.png)
   
   
   ### TEST PLAN
   
   1. Go to a Area chart
   2. Add a metric and a sort by metric of the same name
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to