mrshu opened a new issue #13481:
URL: https://github.com/apache/superset/issues/13481
After updating to Superset 1.0.1 we started running into an issue with the
Athena adapter, where Metrics with uppercase name would stop working with the
following error:
```
Can't resolve label reference for ORDER BY / GROUP BY / DISTINCT etc.
Textual SQL expression 'New_metric' should be explicitly declared as
text('New_metric')
```
Strangely enough, we found out that this issue does not persist when the
name of metric gets lowercased. It therefore seems like the following
issues/PRs may be related:
- https://github.com/apache/superset/issues/5308
- https://github.com/apache/superset/pull/4994
### Expected results
The computation of the defined metric.
### Actual results
An error:
```
Can't resolve label reference for ORDER BY / GROUP BY / DISTINCT etc.
Textual SQL expression 'New_metric' should be explicitly declared as
text('New_metric')
```
The stacktrace is as follows:
```
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/compiler.py",
line 835, in visit_textual_label_reference
col = with_cols[element.element]
KeyError: 'New_metric'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/superset/viz.py", line 540,
in get_df_payload
df = self.get_df(query_obj)
File "/usr/local/lib/python3.8/site-packages/superset/viz.py", line 270,
in get_df
self.results = self.datasource.query(query_obj)
File
"/usr/local/lib/python3.8/site-packages/superset/connectors/sqla/models.py",
line 1295, in query
query_str_ext = self.get_query_str_extended(query_obj)
File
"/usr/local/lib/python3.8/site-packages/superset/connectors/sqla/models.py",
line 767, in get_query_str_extended
sql = self.database.compile_sqla_query(sqlaq.sqla_query)
File "/usr/local/lib/python3.8/site-packages/superset/models/core.py",
line 409, in compile_sqla_query
sql = str(qry.compile(engine, compile_kwargs={"literal_binds": True}))
File "<string>", line 1, in <lambda>
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/elements.py",
line 481, in compile
return self._compiler(dialect, bind=bind, **kw)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/elements.py",
line 487, in _compiler
return dialect.statement_compiler(dialect, self, **kw)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/compiler.py",
line 592, in __init__
Compiled.__init__(self, dialect, statement, **kwargs)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/compiler.py",
line 322, in __init__
self.string = self.process(self.statement, **compile_kwargs)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/compiler.py",
line 352, in process
return obj._compiler_dispatch(self, **kwargs)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/visitors.py",
line 96, in _compiler_dispatch
return meth(self, **kw)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/compiler.py",
line 2201, in visit_select
text = self._compose_select_body(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/compiler.py",
line 2314, in _compose_select_body
text += self.order_by_clause(select, **kwargs)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/compiler.py",
line 2373, in order_by_clause
order_by = select._order_by_clause._compiler_dispatch(self, **kw)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/visitors.py",
line 96, in _compiler_dispatch
return meth(self, **kw)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/compiler.py",
line 1040, in visit_clauselist
text = sep.join(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/compiler.py",
line 1040, in <genexpr>
text = sep.join(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/compiler.py",
line 1043, in <genexpr>
c._compiler_dispatch(self, **kw) for c in clauselist.clauses
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/visitors.py",
line 96, in _compiler_dispatch
return meth(self, **kw)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/compiler.py",
line 1277, in visit_unary
return self._generate_generic_unary_modifier(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/compiler.py",
line 1424, in _generate_generic_unary_modifier
return unary.element._compiler_dispatch(self, **kw) + opstring
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/visitors.py",
line 96, in _compiler_dispatch
return meth(self, **kw)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/compiler.py",
line 837, in visit_textual_label_reference
elements._no_text_coercion(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/elements.py",
line 4757, in _no_text_coercion
util.raise_(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/util/compat.py",
line 182, in raise_
raise exception
sqlalchemy.exc.CompileError: Can't resolve label reference for ORDER BY /
GROUP BY / DISTINCT etc. Textual SQL expression 'New_metric' should be
explicitly declared as text('New_metric')
```
#### Screenshots
Here is what the chart rendering looks like:
And this is what one can find in the Dataset editor (Metrics tab):
#### How to reproduce the bug
1. Go to an Athena-based Dataset in Superset (1.0.1
2. Add a new metric called `New_metric`
3. Create a (say) Bar Chart and choose `New_metric` as the metric to be
used in it
4. See the error after clicking "Run query"
### Environment
- superset version: 1.0.1
- python version: 3.8
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version
of superset.
- [x] I have checked the issue tracker for the same issue and I haven't
found one similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
