yardz commented on pull request #13466: URL: https://github.com/apache/superset/pull/13466#issuecomment-792971844
> I think we should try to avoid such specific prop manipulation logics in the general `Control` renderer. These type of errors should be fixed in each control itself instead. As I don't understand the data flow of the application very well, I made the fix with the least possible impact but with the awareness that it is possibly not the correct way. As the fix was created in another PR, I will close this one because it is neither necessary nor correct. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
