hughhhh commented on a change in pull request #13468:
URL: https://github.com/apache/superset/pull/13468#discussion_r589884012
##########
File path: superset/databases/commands/create.py
##########
@@ -63,7 +67,10 @@ def run(self) -> Model:
security_manager.add_permission_view_menu("database_access",
database.perm)
db.session.commit()
except DAOCreateFailedError as ex:
- logger.exception(ex.exception)
+ event_logger.log_with_context(
+ action=f"db_creation_failed.{ex.__class__.__name__}",
+ engine=database.db_engine_spec.__name__,
Review comment:
I ended up changing all the engine references in the
`event_logger.log_with_context` to pull data from the
`database.db_engine_spec.__name__`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
