robdiciuccio commented on issue #13351:
URL: https://github.com/apache/superset/issues/13351#issuecomment-794312242


   > I would recommend using an accumulation pattern around cleanup that are 
not immediately needed, meaning if for instance we want to remove columns in 
the database, we can remove the field from the model, but delay the related 
database field cleanup in some sort of migrations/next.py where we accumulate 
those cleanup migration scripts and defer until the next big number release 
(say 2.0.0) where downtime may be expected
   
   @mistercrunch agreed, I added an item for accumulating breaking/cleanup 
migrations for the next major release
   
   > It'd be so nice to have blue/green forward compatible stamps on 
migrations, meaning previous version of the app is guaranteed to work with 
future version of the database. In many cases if the migration is not 
blue-green compatible it should be clearly identified as it requires downtime. 
I'd recommend really pushing PRs to meet this req and pushing to using the 
accumulation pattern when that's not the case.
   
   I think the standards set forth in 
[SIP-57](https://github.com/apache/superset/issues/12566) re: breaking changes 
should accomplish this goal, unless you have something else in mind?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to