villebro commented on a change in pull request #13529:
URL: https://github.com/apache/superset/pull/13529#discussion_r590668160
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/FilterSets.tsx
##########
@@ -16,32 +16,25 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { Select, Typography } from 'src/common/components';
-import Button from 'src/components/Button';
-import React, { useState } from 'react';
-import { styled, t, tn } from '@superset-ui/core';
+
+import React, { useEffect, useState, MouseEvent } from 'react';
+import { HandlerFunction, styled, t } from '@superset-ui/core';
import { useDispatch } from 'react-redux';
-import {
- DataMaskState,
- DataMaskUnitWithId,
- MaskWithId,
-} from 'src/dataMask/types';
+import { DataMaskState, DataMaskUnit, MaskWithId } from 'src/dataMask/types';
import { setFilterSetsConfiguration } from
'src/dashboard/actions/nativeFilters';
+import { areObjectsEqual } from 'src/reduxUtils';
import { generateFiltersSetId } from './utils';
import { Filter } from '../../types';
import { useFilters, useDataMask, useFilterSets } from '../state';
import Footer from './Footer';
-import FiltersHeader from './FiltersHeader';
+import FilterSetUnit from './FilterSetUnit';
+import { FilterSet } from '../../../../reducers/types';
Review comment:
nit:
```suggestion
import { FilterSet } from 'src/dashboard/reducers/types';
```
##########
File path: docker/pythonpath_dev/superset_config.py
##########
@@ -75,7 +75,6 @@ class CeleryConfig(object):
CELERY_ANNOTATIONS = {"tasks.add": {"rate_limit": "10/s"}}
CELERY_TASK_PROTOCOL = 1
-
Review comment:
this line will most likely cause linting problems.
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/FilterSets.tsx
##########
@@ -66,27 +77,59 @@ type FilterSetsProps = {
const DEFAULT_FILTER_SET_NAME = t('New filter set');
const FilterSets: React.FC<FilterSetsProps> = ({
+ currentDataMask,
Review comment:
Would be nice to have these in the same style; below we have
`dataMaskApplied`, maybe this could be `dataMaskSelected`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
