ktmud commented on a change in pull request #13496:
URL: https://github.com/apache/superset/pull/13496#discussion_r590713008
##########
File path: superset/connectors/sqla/models.py
##########
@@ -1061,23 +1060,36 @@ def get_sqla_query( # pylint:
disable=too-many-arguments,too-many-locals,too-ma
target_column_is_numeric=col_obj.is_numeric,
is_list_target=is_list_target,
)
- if op in (
- utils.FilterOperator.IN.value,
- utils.FilterOperator.NOT_IN.value,
- ):
- cond = col_obj.get_sqla_col().in_(eq)
- if isinstance(eq, str) and NULL_STRING in eq:
- cond = or_(
- cond,
- col_obj.get_sqla_col() # pylint:
disable=singleton-comparison
- == None,
+ if is_list_target:
Review comment:
Done.
More granular logics could be handled by actual unit tests when we break
down the query generator. I also added "revisit:add-tests" label to mark this
as a followup item.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
