rusackas commented on a change in pull request #13500:
URL: https://github.com/apache/superset/pull/13500#discussion_r591884630



##########
File path: superset-frontend/src/views/CRUD/welcome/Welcome.tsx
##########
@@ -27,6 +27,7 @@ import {
   createErrorHandler,
   getRecentAcitivtyObjs,
   mq,
+  getMineObjs,

Review comment:
       This is a stupid nit, but I'll throw it out there... `Mine` makes this 
explicit about what it's used for (which I like) but there's something in me 
that wants to rename this to `getMyObjs` since it just _sounds_ better. We 
should probably leave it alone.... but just it does sound weird to my brain, so 
I'm just just hemming and hawing about it :P




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to