simcha90 commented on a change in pull request #13569:
URL: https://github.com/apache/superset/pull/13569#discussion_r592165634



##########
File path: 
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -82,6 +83,7 @@ export default function PluginFilterSelect(props: 
PluginFilterSelectProps) {
     handleChange(currentValue ?? []);
   }, [
     JSON.stringify(currentValue),
+    sortAscending,

Review comment:
       why not put it in `extraFormData`? and if we not put it here so may be 
no need to add it this array?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to