kristw commented on a change in pull request #13520:
URL: https://github.com/apache/superset/pull/13520#discussion_r592807324
##########
File path: superset-frontend/src/explore/controlUtils/getControlConfig.ts
##########
@@ -59,6 +45,20 @@ export function findControlItem(
);
}
+const getMemoizedControlConfig = memoizeOne(
Review comment:
Is this one just changing location?
##########
File path: superset-frontend/spec/javascripts/explore/controlUtils_spec.tsx
##########
@@ -209,14 +214,14 @@ describe('controlUtils', () => {
let controlItem = findControlItem(
Review comment:
Could we do `let controlItem: CustomControlItem`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
