ktmud opened a new pull request #13584: URL: https://github.com/apache/superset/pull/13584
### SUMMARY Two small changes to: 1. Add ErrorBoundary to control items, so a JS error in a single chart control does not crash the whole page. Error may happen more often with the addition of more and more custom controls. 2. Allow `CollectionControl` to load control components from `@superset-ui/chart-controls`' `sharedControlComponents`. The plan is to move all control components to `chart-controls` so they have better isolation and less dependencies. Currently new DnD controls are still added to `superset-frontend`, that's fine, too. We'll consolidate both once [the monorepo merge](https://github.com/apache/superset/issues/13013) is completed. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF #### Before A JS error may cause the whole page to crash. #### After <img width="401" alt="wrap-control-error" src="https://user-images.githubusercontent.com/335541/110876396-446da200-828c-11eb-8821-4e131f01a6f8.png";> ### TEST PLAN Tested manually 1. Add JS error to one of the chart control, e.g. reference an undefined variable in `render` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/335541/110876396-446da200-828c-11eb-8821-4e131f01a6f8.png"](https://user-images.githubusercontent.com/335541/110876396-446da200-828c-11eb-8821-4e131f01a6f8.png"){kind=link}