junlincc edited a comment on pull request #13563:
URL: https://github.com/apache/superset/pull/13563#issuecomment-797162975


   Tested locally and learned something new today, LGTM! Thanks for the fix! 🙏 
@eschutho 
   With FF enabled, I can type and delete in both sql editor and para modal ✅
   i can open a new tab with ctrl+t ✅
   I am able to type, close, reopen the modal and the data persists ✅
   
   Functionality ✅
   
   
https://user-images.githubusercontent.com/67837651/110876681-d5dd1400-828c-11eb-9d8d-13c7993d6ee1.mov
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to