serenajiang commented on a change in pull request #13602:
URL: https://github.com/apache/superset/pull/13602#discussion_r593387639
##########
File path: superset/sql_parse.py
##########
@@ -278,7 +285,11 @@ def _extract_from_token( # pylint:
disable=too-many-branches
table_name_preceding_token = False
for item in token.tokens:
- if item.is_group and not self._is_identifier(item):
+ if (item.is_group and not self._is_identifier(item)) or (
Review comment:
`item.is_group and (not self.is_identifier(item) or
isinstance(item.tokens[0], Parenthesis))`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]