eschutho commented on a change in pull request #13563:
URL: https://github.com/apache/superset/pull/13563#discussion_r593430415
##########
File path: superset-frontend/src/components/AsyncAceEditor/index.tsx
##########
@@ -150,7 +151,8 @@ export default function AsyncAceEditor(
mode={mode}
theme={theme}
tabSize={tabSize}
- {...props}
+ defaultValue={defaultValue}
+ {...{ ...props, value: props.value || '' }}
Review comment:
ha, yeah, that was my first implementation, but often people like to see
the "rest" props at the end, and so I anticipated someone changing this order
in the context of "cleanup". I think I found a way around this.. lmk what you
think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
