etr2460 commented on a change in pull request #13606:
URL: https://github.com/apache/superset/pull/13606#discussion_r593547291
##########
File path: superset/connectors/sqla/models.py
##########
@@ -482,7 +496,7 @@ class SqlaTable( # pylint:
disable=too-many-public-methods,too-many-instance-at
"fetch_values_predicate",
"extra",
]
- update_from_object_fields = [f for f in export_fields if not f ==
"database_id"]
+ update_from_object_fields = [f for f in export_fields if f !=
"database_id"]
Review comment:
ran into this while debugging and got really confused. this seems clearer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
