junlincc opened a new issue #13633: URL: https://github.com/apache/superset/issues/13633
Currently user can create saved from edit dataset modal, and ad hoc metrics from control panel popover using SQL expression. There's no way to validate the expression before saving. Invalid ones cause error when click RUN QUERY. Proposed change: Alarm user the syntax error on save metric(in both popover and edit dataset modal), instead of on RUN QUERY https://user-images.githubusercontent.com/67837651/111210889-083b8980-858b-11eb-8a61-e085d95ad980.mov https://user-images.githubusercontent.com/67837651/111210943-1689a580-858b-11eb-8b4a-cfbab55a2a06.mov ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
