suddjian commented on issue #13632: URL: https://github.com/apache/superset/issues/13632#issuecomment-799763151
This looks great! Thank you for the well organized and researched SIP. I suggest removing "utils" as a category. In my experience, utils usually ends up being a grab bag of random things. I'd move "logger" to a "services" category, and split out the rest into either their feature folders, or into files organized by their domain (`stringFns.ts`, `urlFns`, `dates`, etc.). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
