AAfghahi commented on a change in pull request #13630:
URL: https://github.com/apache/superset/pull/13630#discussion_r595236041
##########
File path: superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
##########
@@ -74,28 +69,34 @@ class ShareSqlLabQuery extends React.Component {
})
.catch(response => {
getClientErrorObject(response).then(() => {
- this.props.addDangerToast(t('There was an error with your request'));
+ addDangerToast(t('There was an error with your request'));
});
});
- }
+ };
- getCopyUrlForSavedQuery(callback) {
+ const getCopyUrlForSavedQuery = (callback: Function) => {
let savedQueryToastContent;
- if (this.props.queryEditor.remoteId) {
+ if (queryEditor.remoteId) {
Review comment:
Ok, I changed it to null and tested it and the intended functionality is
there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
