[GitHub] [superset] lyndsiWilliams opened a new pull request #13647: Moving some things around

[GitBox]

lyndsiWilliams opened a new pull request #13647:
URL: https://github.com/apache/superset/pull/13647


   ### SUMMARY
   Moved CTAS/CVAS Schema Field Closer to the "Allow Create Table As" In Edit 
Datasource Modal. This required nested conditional rendering, so I had to use 
some useState/useEffect in order to hold that state at a higher level for all 
functions to run properly.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   #### Field before:
   <img width="750" alt="ctascvas-before" 
src="https://user-images.githubusercontent.com/55605634/106359617-77aa3200-62d9-11eb-9484-63c01d9df377.png";>
   
   #### Field after:
   <img width="750" alt="ctascvas-after-1" 
src="https://user-images.githubusercontent.com/55605634/106359624-7e38a980-62d9-11eb-8911-97b2709c4cc7.png";>
   <img width="750" alt="ctascvas-after-2" 
src="https://user-images.githubusercontent.com/55605634/106359626-809b0380-62d9-11eb-963a-52702ca996b7.png";>
   <img width="750" alt="ctascvas-after-3" 
src="https://user-images.githubusercontent.com/55605634/106359627-8264c700-62d9-11eb-95ed-838ba5d3b5ff.png";>
   
   ### TEST PLAN
   Tests will ensure that all elements are rendered in their respectively 
appropriate conditions.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org