junlincc commented on issue #8639: URL: https://github.com/apache/superset/issues/8639#issuecomment-800799054
thanks both! @etr2460 and @bkyryliuk To summarize - Superset currently only supports hard delete entities, which needs to be changed to soft delete - Entity include datasets, charts, dashboards and saved queries - Soft deleted records will not appear in search results or in list view, but they are not permanently deleted within a set period of time (time to live) - Only system admin can set the _time to live_ ,at database level, for the users - Soft deleted records are temporary stored in a trash can - Soft deleted records can be restored by both admin and users from the trash can I'm not very familiar with the role permission in Superset tbh. By reading the documentation, seems like we should change the logic of can_delete, and add something like can_restore? _Model & Action: models are entities like Dashboard, Slice, or User. Each model has a fixed set of permissions, like can_edit, can_show, can_delete, can_list, can_add, and so on. For example, you can allow a user to delete dashboards by adding can_delete on Dashboard entity to a role and granting this user that role._ @amitmiran137 thoughts? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
