etr2460 commented on pull request #13684: URL: https://github.com/apache/superset/pull/13684#issuecomment-801629426
@betodealmeida even though it lives in controls.jsx too? weird... So the list in controls.jsx needs to be a superset of all time granularities that are supported across all db engine specs? And if someone wants to add a custom db engine spec with custom time grains, it won't format properly on the client? obviously not blocking this PR, but that's _weird_ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
