villebro commented on a change in pull request #13622:
URL: https://github.com/apache/superset/pull/13622#discussion_r596626801
##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -145,7 +145,7 @@ def convert_dttm(cls, target_type: str, dttm: datetime) ->
Optional[str]:
tt = target_type.upper()
if tt == utils.TemporalType.DATE:
return f"TO_DATE('{dttm.date().isoformat()}', 'YYYY-MM-DD')"
- if tt == utils.TemporalType.TIMESTAMP:
+ if "TIMESTAMP" in tt or "DATETIME" in tt:
Review comment:
Previously "TIMESTAMP WITH TIMEZONE" was not being picked up, nor was
"DATETIME" (`utils.TemporalType` needs a good refactor, too, but will leave
that to a follow-up PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
