villebro commented on a change in pull request #13687:
URL: https://github.com/apache/superset/pull/13687#discussion_r596719257
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/ScopingTree.tsx
##########
@@ -29,29 +29,36 @@ type ScopingTreeProps = {
updateFormValues: (values: any) => void;
formScope?: Scope;
initialScope: Scope;
+ chartId?: number;
Review comment:
Should we rather make this `excludedChartIds?: number[]`? Now it's
unclear what the component needs the `chartId` for, and it might well be that
we want to exclude some other charts other than the caller.
##########
File path: superset-frontend/src/dashboard/components/SliceHeader.tsx
##########
@@ -0,0 +1,184 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { FC } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { Tooltip } from 'src/common/components/Tooltip';
+import { useSelector } from 'react-redux';
+import EditableTitle from '../../components/EditableTitle';
+import SliceHeaderControls from './SliceHeaderControls';
+import FiltersBadge from '../containers/FiltersBadge';
+import Icon from '../../components/Icon';
+import { RootState } from '../types';
+import { Slice } from '../../types/Chart';
+import FilterIndicator from './FiltersBadge/FilterIndicator';
+
+type SliceHeaderProps = {
+ innerRef?: string;
+ slice: Slice;
+ isExpanded?: boolean;
+ isCached?: boolean[];
+ cachedDttm?: string[];
+ updatedDttm?: number;
+ updateSliceName?: (arg0: string) => void;
+ toggleExpandSlice?: Function;
+ forceRefresh?: Function;
+ exploreChart?: Function;
+ exportCSV?: Function;
+ editMode?: boolean;
+ isFullSize?: boolean;
+ annotationQuery?: object;
+ annotationError?: object;
+ sliceName?: string;
+ supersetCanExplore?: boolean;
+ supersetCanCSV?: boolean;
+ sliceCanEdit?: boolean;
+ componentId: string;
+ dashboardId: number;
+ filters: object;
+ addSuccessToast: Function;
+ addDangerToast: Function;
+ handleToggleFullSize: Function;
+ chartStatus: string;
+};
Review comment:
Nice, thanks for converting this file to TS!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
