villebro commented on a change in pull request #13688:
URL: https://github.com/apache/superset/pull/13688#discussion_r596859328
##########
File path: superset-frontend/src/dataMask/reducer.ts
##########
@@ -28,13 +28,11 @@ import {
UpdateDataMask,
} from './actions';
-export function getInitialMask(id: string): MaskWithId {
- return {
- id,
- extraFormData: {},
- currentState: {},
- };
-}
+export const getInitialMask = (id: string): MaskWithId => ({
+ id,
+ extraFormData: {},
+ currentState: {},
+});
Review comment:
Is there a reason we're changing this to an arrow function? Personally I
prefer to keep exported functions as vanilla functions vs arrows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
