ktmud commented on a change in pull request #13695:
URL: https://github.com/apache/superset/pull/13695#discussion_r597422380
##########
File path: superset-frontend/src/dashboard/util/getFilterScopeFromNodesTree.js
##########
@@ -38,9 +56,24 @@ function getTabChildrenScope({
([key, { scope }]) => scope && scope.length && key === scope[0],
))
) {
+ // get all charts from tabChildren that is not in scope
+ const immuneChartIdsFromTabsNotInScope = getChartIdsFromTabsNotInScope({
+ tabs: tabChildren,
+ tabsInScope: flatMap(tabScopes, ({ scope }) => scope),
+ });
+ const immuneChartsFromTabsInScope = flatMap(
Review comment:
Should this be called `immuneChartIdsFromTabsInScope`, too?
##########
File path: superset-frontend/src/dashboard/util/getFilterScopeFromNodesTree.js
##########
@@ -22,11 +22,29 @@ import { flatMap, isEmpty } from 'lodash';
import { CHART_TYPE, TAB_TYPE } from './componentTypes';
import { getChartIdAndColumnFromFilterKey } from './getDashboardFilterKey';
+function getChartIdsFromTabsNotInScope({ tabs = [], tabsInScope = [] }) {
Review comment:
Hate to make function names even longer, but do you think
`getImmuneChartIdsFromTabsNotInScope` would make this easier to understand?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
